Modify bug that show header when not use header#1297
Closed
uyeong wants to merge 1 commit intostorybookjs:masterfrom
uyeong:master
Closed
Modify bug that show header when not use header#1297uyeong wants to merge 1 commit intostorybookjs:masterfrom uyeong:master
uyeong wants to merge 1 commit intostorybookjs:masterfrom
uyeong:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1297 +/- ##
=======================================
Coverage 13.76% 13.76%
=======================================
Files 201 201
Lines 4620 4620
Branches 506 498 -8
=======================================
Hits 636 636
- Misses 3538 3564 +26
+ Partials 446 420 -26
Continue to review full report at Codecov.
|
ndelangen
approved these changes
Jun 16, 2017
Member
ndelangen
left a comment
ndelangen
left a comment
There was a problem hiding this comment.
Looks ok to me,
Please do note that we're very likely going to move the the content of the info addon into a panel.
Member
|
Thanks for this PR @uyeong ! |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
I have modified bug that show header when not use header.
How to test
When I pass
header: falseof options, header is displayedSo I have modified code like below image.